If you say that someone should do something while the going is good, you are advising them to do it while things are going well and they still have the opportunity, because you think it will become much more difficult to do.